Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support C# 8 nullable reference types #98

Merged
merged 17 commits into from
Jul 12, 2021
Merged

Add support C# 8 nullable reference types #98

merged 17 commits into from
Jul 12, 2021

Conversation

rafaelsc
Copy link
Contributor

What issue does this PR address?
#97

Does this PR introduce a breaking change?
No

Please check if the PR fulfills these requirements

  • The commit follows our guidelines
  • Unit Tests for the changes have been added (for bug fixes / features)

nblumhardt
nblumhardt reviewed Jul 23, 2020
View reviewed changes
Copy link
Member

@nblumhardt nblumhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Had a couple of minor comments.

src/Serilog.Sinks.Console/Serilog.Sinks.Console.csproj Outdated Show resolved Hide resolved
src/Serilog.Sinks.Console/Sinks/SystemConsole/Formatting/ThemedJsonValueFormatter.cs Outdated Show resolved Hide resolved
src/Serilog.Sinks.Console/Sinks/SystemConsole/Formatting/ThemedJsonValueFormatter.cs Outdated Show resolved Hide resolved
src/Serilog.Sinks.Console/Sinks/SystemConsole/Output/EventPropertyTokenRenderer.cs Outdated Show resolved Hide resolved
src/Serilog.Sinks.Console/Sinks/SystemConsole/Rendering/ThemedMessageTemplateRenderer.cs Outdated Show resolved Hide resolved
@rafaelsc
Copy link
Contributor Author

Updated to have the same behaver of serilog/serilog#1467

@nblumhardt
Copy link
Member

We have some build problems on dev, I'll sort out any remaining gotchas over there :-)

@nblumhardt nblumhardt closed this Jul 12, 2021
@nblumhardt nblumhardt reopened this Jul 12, 2021
@nblumhardt nblumhardt merged commit ffc2c0f into serilog:dev Jul 12, 2021
@nblumhardt nblumhardt mentioned this pull request Jul 12, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nblumhardt nblumhardt nblumhardt left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rafaelsc @nblumhardt